From c75d319ee6b657402b902b1b46b9d3f2d0e5370b Mon Sep 17 00:00:00 2001 From: Bryce Russell Date: Thu, 9 Feb 2023 13:12:15 -0600 Subject: [PATCH] Fix types for TableHTMLAttributes (#6197) * Fix types for TableHTMLAttributes - Add 'string' type to 'border' attribute - Add 'false | true' to 'frame' attribute Thanks Princesseuh for helping * Create sixty-scissors-refuse.md * Make changeset more descriptive * Fix previous changset --------- Co-authored-by: BryceRussell <19967622+BryceRussell@users.noreply.github.com> --- .changeset/sixty-scissors-refuse.md | 6 ++++++ packages/astro/astro-jsx.d.ts | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/sixty-scissors-refuse.md diff --git a/.changeset/sixty-scissors-refuse.md b/.changeset/sixty-scissors-refuse.md new file mode 100644 index 0000000000..71452bfae3 --- /dev/null +++ b/.changeset/sixty-scissors-refuse.md @@ -0,0 +1,6 @@ +--- +'astro': patch +--- + +Fix `border` and `frame` attribute types on `TableHTMLAttributes` interface + diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 38e924523f..fc38e5c1b3 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -936,10 +936,10 @@ declare namespace astroHTML.JSX { interface TableHTMLAttributes extends HTMLAttributes { align?: 'left' | 'center' | 'right' | undefined | null; bgcolor?: string | undefined | null; - border?: number | undefined | null; + border?: string | number | undefined | null; cellpadding?: number | string | undefined | null; cellspacing?: number | string | undefined | null; - frame?: boolean | undefined | null; + frame?: boolean | 'false' | 'true' | undefined | null; rules?: 'none' | 'groups' | 'rows' | 'columns' | 'all' | undefined | null; summary?: string | undefined | null; width?: number | string | undefined | null;