Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-30 22:03:56 -05:00
Code Issues Activity

Fixes windows test flakiness (#2744)

Browse source 
* Fixes windows test flakiness

* Tighten up the try/catch
This commit is contained in:
Matthew Phillips 2022-03-09 16:44:12 -05:00 committed by GitHub
parent 0281d6a65b
commit c139829b10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 45 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
packages/astro/src/core/build/fs.ts
View file

@ -4,6 +4,8 @@ import fs from 'fs';
import npath from 'path';
import { fileURLToPath } from 'url';
const isWindows = process.platform === 'win32';
export function emptyDir(dir: string, skip?: Set<string>): void {
for (const file of fs.readdirSync(dir)) {
if (skip?.has(file)) {
@ -11,7 +13,20 @@ export function emptyDir(dir: string, skip?: Set<string>): void {
}
const abs = npath.resolve(dir, file);
// baseline is Node 12 so can't use rmSync :(
if (fs.lstatSync(abs).isDirectory()) {
let isDir = false;
try {
isDir = fs.lstatSync(abs).isDirectory();
} catch (err: any) {
// Taken from:
// https://github.com/isaacs/rimraf/blob/9219c937be159edbdf1efa961f2904e863c3ce2d/rimraf.js#L293-L296
if (err.code === 'EPERM' && isWindows) {
fixWinEPERMSync(abs, err);
} else {
throw err;
}
}
if (isDir) {
emptyDir(abs);
fs.rmdirSync(abs);
} else {
@ -26,3 +41,32 @@ export function prepareOutDir(astroConfig: AstroConfig) {
return emptyDir(outDir, new Set(['.git']));
}
}
function fixWinEPERMSync(path: string, error: Error) {
try {
fs.chmodSync(path, 0o666);
} catch (er2: any) {
if (er2.code === 'ENOENT') {
return;
} else {
throw error;
}
}
let stats;
try {
stats = fs.statSync(path);
} catch (er3: any) {
if (er3.code === 'ENOENT') {
return;
} else {
throw error;
}
}
if (stats.isDirectory()) {
emptyDir(path);
} else {
fs.unlinkSync(path);
}
}