Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

fix: reuse storage objects in sessions (#13415)

Browse source
This commit is contained in:
Matt Kane 2025-03-13 14:04:35 +00:00 • committed by GitHub
parent fd65296626
commit be866a1d1d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.changeset/dull-papers-fry.md Normal file
View file

@ -0,0 +1,6 @@
---
'astro': patch
---
Reuses experimental session storage object between requests. This prevents memory leaks and improves performance for drivers that open persistent connections to a database.

11
packages/astro/src/core/session.ts
View file

@ -76,6 +76,8 @@ export class AstroSession<TDriver extends SessionDriverName = any> {
// preserving in-memory changes and deletions.
#partial = true;
static #sharedStorage = new Map<string, Storage>();
constructor(
cookies: AstroCookies,
{
@ -402,6 +404,14 @@ export class AstroSession<TDriver extends SessionDriverName = any> {
return this.#storage;
}
// We reuse the storage object if it has already been created.
// We don't need to worry about the config changing because editing it
// will always restart the process.
if (AstroSession.#sharedStorage.has(this.#config.driver)) {
this.#storage = AstroSession.#sharedStorage.get(this.#config.driver);
return this.#storage!;
}
if (this.#config.driver === 'test') {
this.#storage = (this.#config as SessionConfig<'test'>).options.mockStorage;
return this.#storage!;
@ -468,6 +478,7 @@ export class AstroSession<TDriver extends SessionDriverName = any> {
this.#storage = createStorage({
driver: driver(this.#config.options),
});
AstroSession.#sharedStorage.set(this.#config.driver, this.#storage);
return this.#storage;
} catch (err) {
throw new AstroError(