From bd7effcf720c2a79d130c72b323377f33fb7afe8 Mon Sep 17 00:00:00 2001
From: Arsh <69170106+lilnasy@users.noreply.github.com>
Date: Wed, 27 Mar 2024 21:45:23 +0530
Subject: [PATCH] qol(runtime): clarify message about unavailable headers
(#10583)
* qol(runtime): clarify message about unavailable headers
* update test assertion
---
packages/astro/src/core/request.ts | 2 +-
packages/astro/test/static-build.test.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/packages/astro/src/core/request.ts b/packages/astro/src/core/request.ts
index 85e3f5fb35..2e77a89c14 100644
--- a/packages/astro/src/core/request.ts
+++ b/packages/astro/src/core/request.ts
@@ -70,7 +70,7 @@ export function createRequest({
get() {
logger.warn(
null,
- `\`Astro.request.headers\` is not available in "static" output mode. To enable header access: set \`output: "server"\` or \`output: "hybrid"\` in your config file.`
+ `\`Astro.request.headers\` is unavailable in "static" output mode, and in prerendered pages within "hybrid" and "server" output modes. If you need access to request headers, make sure that \`output\` is configured as either \`"server"\` or \`output: "hybrid"\` in your config file, and that the page accessing the headers is rendered on-demand.`
);
return _headers;
},
diff --git a/packages/astro/test/static-build.test.js b/packages/astro/test/static-build.test.js
index 126e101160..5fc16ca0ac 100644
--- a/packages/astro/test/static-build.test.js
+++ b/packages/astro/test/static-build.test.js
@@ -186,7 +186,7 @@ describe('Static build', () => {
it('warns when accessing headers', async () => {
let found = false;
for (const log of logs) {
- if (/`Astro\.request\.headers` is not available in "static" output mode/.test(log.message)) {
+ if (/`Astro\.request\.headers` is unavailable in "static" output mode/.test(log.message)) {
found = true;
}
}