mirror of
https://github.com/withastro/astro.git
synced 2025-01-27 22:19:04 -05:00
Removes trailing dash from generated slugs in markdown (#3044)
* fixed header slugs in markdown if ends with a dash * added changeset * removes trailing dash only if slug was created * updated test * updated change level from patch to minor
This commit is contained in:
parent
4bb96ac8e5
commit
ba11b33996
3 changed files with 11 additions and 2 deletions
5
.changeset/cold-bears-sneeze.md
Normal file
5
.changeset/cold-bears-sneeze.md
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
'@astrojs/markdown-remark': minor
|
||||||
|
---
|
||||||
|
|
||||||
|
fixed generated slugs in markdown that ends with a dash
|
|
@ -53,7 +53,11 @@ export default function createCollectHeaders() {
|
||||||
node as any
|
node as any
|
||||||
).value = `<${node.tagName} id={${node.properties.id}}>${raw}</${node.tagName}>`;
|
).value = `<${node.tagName} id={${node.properties.id}}>${raw}</${node.tagName}>`;
|
||||||
} else {
|
} else {
|
||||||
node.properties.id = slugger.slug(text);
|
let slug = slugger.slug(text);
|
||||||
|
|
||||||
|
if (slug.endsWith('-')) slug = slug.slice(0, -1);
|
||||||
|
|
||||||
|
node.properties.id = slug;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -54,7 +54,7 @@ describe('expressions', () => {
|
||||||
chai
|
chai
|
||||||
.expect(code)
|
.expect(code)
|
||||||
.to.equal(
|
.to.equal(
|
||||||
'<h1 id="-foo--is-a-shorthand-for--foo-foo-"><code is:raw>{ foo }</code> is a shorthand for <code is:raw>{ foo: foo }</code></h1>'
|
'<h1 id="-foo--is-a-shorthand-for--foo-foo"><code is:raw>{ foo }</code> is a shorthand for <code is:raw>{ foo: foo }</code></h1>'
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
Loading…
Add table
Reference in a new issue