Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

Fix db.run() type signature in production (#10566)

Browse source 
* deps: bump drizzle to latest patch

* chore: changeset

* feat(test): db.run output
This commit is contained in:
Ben Holmes 2024-03-26 13:43:04 -04:00 • committed by GitHub
parent 5f7e9c47e0
commit b5a80405b9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 59 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/wild-nails-call.md Normal file
View file

@ -0,0 +1,5 @@
---
"@astrojs/db": patch
---
Fix `db.run()` type signature in production.

2
packages/db/package.json
View file

@ -66,7 +66,7 @@
"@libsql/client": "^0.5.5",
"async-listen": "^3.0.1",
"deep-diff": "^1.0.2",
"drizzle-orm": "^0.30.2",
"drizzle-orm": "^0.30.4",
"github-slugger": "^2.0.0",
"kleur": "^4.1.5",
"nanoid": "^5.0.1",

34
packages/db/test/basics.test.js
View file

@ -73,6 +73,23 @@ describe('astro:db', () => {
expect($('.session-id').text()).to.equal('12345');
expect($('.username').text()).to.equal('Mario');
});
it('Prints authors from raw sql call', async () => {
const json = await fixture.fetch('run.json').then((res) => res.json());
expect(json).to.deep.equal({
columns: ['_id', 'name', 'age2'],
columnTypes: ['INTEGER', 'TEXT', 'INTEGER'],
rows: [
[1, 'Ben', null],
[2, 'Nate', null],
[3, 'Erika', null],
[4, 'Bjorn', null],
[5, 'Sarah', null],
],
rowsAffected: 0,
lastInsertRowid: null,
});
});
});
describe('development --remote', () => {
@ -137,6 +154,23 @@ describe('astro:db', () => {
expect($('.session-id').text()).to.equal('12345');
expect($('.username').text()).to.equal('Mario');
});
it('Prints authors from raw sql call', async () => {
const json = await fixture.fetch('run.json').then((res) => res.json());
expect(json).to.deep.equal({
columns: ['_id', 'name', 'age2'],
columnTypes: ['INTEGER', 'TEXT', 'INTEGER'],
rows: [
[1, 'Ben', null],
[2, 'Nate', null],
[3, 'Erika', null],
[4, 'Bjorn', null],
[5, 'Sarah', null],
],
rowsAffected: 0,
lastInsertRowid: null,
});
});
});
describe('build --remote', () => {

12
packages/db/test/fixtures/basics/src/pages/run.json.ts vendored Normal file
View file

@ -0,0 +1,12 @@
/// <reference types="@astrojs/db" />
import type { APIRoute } from 'astro';
import { db, sql } from 'astro:db';
export const GET: APIRoute = async () => {
const authors = await db.run(sql`SELECT * FROM Author`);
return new Response(JSON.stringify(authors), {
headers: {
'content-type': 'application/json',
},
});
};

11
pnpm-lock.yaml generated
View file

@ -3842,8 +3842,8 @@ importers:
specifier: ^1.0.2
version: 1.0.2
drizzle-orm:
specifier: ^0.30.2
version: 0.30.2(@libsql/client@0.5.6)
specifier: ^0.30.4
version: 0.30.4(@libsql/client@0.5.6)
github-slugger:
specifier: ^2.0.0
version: 2.0.0
@ -10133,8 +10133,8 @@ packages:
engines: {node: '>=10'}
dev: true
/drizzle-orm@0.30.2(@libsql/client@0.5.6):
resolution: {integrity: sha512-DNd3djg03o+WxZX3pGD8YD+qrWT8gbrbhaZ2W0PVb6yH4rtM/VTB92cTGvumcRh7SSd2KfV0NWYDB70BHIXQTg==}
/drizzle-orm@0.30.4(@libsql/client@0.5.6):
resolution: {integrity: sha512-kWoSMGbrOFkmkAweLTFtHJMpN+nwhx89q0mLELqT2aEU+1szNV8jrnBmJwZ0WGNp7J7yQn/ezEtxBI/qzTSElQ==}
peerDependencies:
'@aws-sdk/client-rds-data': '>=3'
'@cloudflare/workers-types': '>=3'
@ -10148,6 +10148,7 @@ packages:
'@types/react': '>=18'
'@types/sql.js': '*'
'@vercel/postgres': '*'
'@xata.io/client': '*'
better-sqlite3: '>=7'
bun-types: '*'
expo-sqlite: '>=13.2.0'
@ -10184,6 +10185,8 @@ packages:
optional: true
'@vercel/postgres':
optional: true
'@xata.io/client':
optional: true
better-sqlite3:
optional: true
bun-types: