Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-13 22:11:20 -05:00
Code Issues Activity

astro/cli/install-package.ts: whichPm may return null if ran in an empty directory (#10782)

Browse source
This commit is contained in:
Meghan Denny 2024-04-15 02:12:07 -07:00 • committed by GitHub
parent af1af9faee
commit b0589d0553
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/many-hairs-jump.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Handles possible null value when calling `which-pm` during dynamic package installation

2
packages/astro/src/cli/install-package.ts
View file

@ -101,7 +101,7 @@ async function installPackage(
logger: Logger logger: Logger
): Promise<boolean> { ): Promise<boolean> {
const cwd = options.cwd ?? process.cwd(); const cwd = options.cwd ?? process.cwd();
const packageManager = (await whichPm(cwd)).name ?? 'npm'; const packageManager = (await whichPm(cwd))?.name ?? 'npm';
const installCommand = getInstallCommand(packageNames, packageManager); const installCommand = getInstallCommand(packageNames, packageManager);
if (!installCommand) { if (!installCommand) {