Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-24 23:21:57 -05:00
Code Issues Activity

fix(redirects): correctly compute the status code in redirects (#9657)

Browse source
This commit is contained in:
Emanuele Stoppa 2024-01-10 13:47:07 +00:00 • committed by GitHub
parent a1b56ee1fa
commit a4f90d95ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/honest-seas-raise.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Fixes a bug where the custom status code wasn't correctly computed in the dev server

4
packages/astro/src/core/redirects/helpers.ts
View file

@ -36,8 +36,8 @@ export function redirectRouteGenerate(redirectRoute: RouteData, data: Params): s
export function redirectRouteStatus(redirectRoute: RouteData, method = 'GET'): ValidRedirectStatus {
const routeData = redirectRoute.redirectRoute;
if (typeof routeData?.redirect === 'object') {
return routeData.redirect.status;
if (routeData && typeof redirectRoute.redirect === 'object') {
return redirectRoute.redirect.status;
} else if (method !== 'GET') {
return 308;
}

8
packages/astro/src/core/routing/manifest/create.ts
View file

@ -477,7 +477,13 @@ export function createRouteManifest(
pathname: pathname || void 0,
prerender: false,
redirect: to,
redirectRoute: routes.find((r) => r.route === to),
redirectRoute: routes.find((r) => {
if (typeof to === 'object') {
return r.route === to.destination;
} else {
return r.route === to;
}
}),
fallbackRoutes: [],
};