Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-06 22:10:10 -05:00
Code Issues Activity

Properly await on children before hydrating in Safari (#3891)

Browse source
This commit is contained in:
Matthew Phillips 2022-07-11 14:10:23 -04:00 committed by GitHub
parent 1cc5b78905
commit 9cf7e40641
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/forty-colts-ring.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fix Safari client:visible refresh bug

2
packages/astro/src/runtime/server/astro-island.ts
View file

@ -42,7 +42,7 @@ declare const Astro: {
public hydrator: any; public hydrator: any;
static observedAttributes = ['props']; static observedAttributes = ['props'];
connectedCallback() { connectedCallback() {
if (!this.getAttribute('await-children') || this.firstChild) { if (!this.hasAttribute('await-children') || this.firstChild) {
this.childrenConnectedCallback(); this.childrenConnectedCallback();
} else { } else {
// connectedCallback may run *before* children are rendered (ex. HTML streaming) // connectedCallback may run *before* children are rendered (ex. HTML streaming)