Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-23 21:53:55 -05:00
Code Issues Activity

Disabling unreliable E2E test for further investigation (#3560)

Browse source 
* fixing reliability issue in component HMR tests

* fix: test change snuck into the last commit

* TEMP: logging to track down ubuntu CI failure

* disabling svelte test for now

* reverting unrelated .d.ts change
This commit is contained in:
Tony Sullivan 2022-06-10 18:18:11 +00:00 committed by GitHub
parent 6e8391365a
commit 99ee40ced0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 54 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/astro/e2e/fixtures/multiple-frameworks/src/components/SvelteCounter.svelte
View file

@ -1,7 +1,6 @@
<script>
export let id;
let children;
let count = 0;
function add() {

75
packages/astro/e2e/multiple-frameworks.test.js
View file

@ -1,5 +1,4 @@
import { test as base, expect } from '@playwright/test';
import os from 'os';
import { loadFixture } from './test-utils.js';
const test = base.extend({
@ -111,49 +110,83 @@ test.describe('Multiple frameworks', () => {
test('Page template', async ({ astro, page }) => {
await page.goto('/');
// 1: updating the page template
const preactSlot = page.locator('#preact-counter + .counter-message');
await expect(preactSlot, 'initial slot content').toHaveText('Hello Preact!');
const slot = page.locator('#preact-counter + .counter-message');
await expect(slot, 'initial slot content').toHaveText('Hello Preact!');
await astro.editFile('./src/pages/index.astro', (content) =>
content.replace('Hello Preact!', 'Hello Preact, updated!')
);
await expect(preactSlot, 'slot content updated').toHaveText('Hello Preact, updated!');
await expect(slot, 'slot content updated').toHaveText('Hello Preact, updated!');
});
test('React component', async ({ astro, page }) => {
await page.goto('/');
// Edit the react component
const count = await page.locator('#react-counter pre');
await expect(count, 'initial count updated to 0').toHaveText('0');
await astro.editFile('./src/components/ReactCounter.jsx', (content) =>
content.replace('useState(0)', 'useState(5)')
);
const reactCount = await page.locator('#react-counter pre');
await expect(reactCount, 'initial count updated to 5').toHaveText('5');
await expect(count, 'initial count updated to 5').toHaveText('5');
});
// TODO: HMR works on Ubuntu, why is this specific test failing in CI?
const it = os.platform() === 'linux' ? test.skip : test;
it('Svelte component', async ({ astro, page }) => {
test('Preact component', async ({ astro, page }) => {
await page.goto('/');
// Edit the svelte component's style
const svelteCounter = page.locator('#svelte-counter');
await expect(svelteCounter, 'initial background is white').toHaveCSS(
'background-color',
'rgb(255, 255, 255)'
const count = await page.locator('#preact-counter pre');
await expect(count, 'initial count updated to 0').toHaveText('0');
await astro.editFile('./src/components/PreactCounter.tsx', (content) =>
content.replace('useState(0)', 'useState(5)')
);
await expect(count, 'initial count updated to 5').toHaveText('5');
});
test('Solid component', async ({ astro, page }) => {
await page.goto('/');
const count = await page.locator('#solid-counter pre');
await expect(count, 'initial count updated to 0').toHaveText('0');
await astro.editFile('./src/components/SolidCounter.tsx', (content) =>
content.replace('createSignal(0)', 'createSignal(5)')
);
await expect(count, 'initial count updated to 5').toHaveText('5');
});
// TODO: re-enable this test when #3559 is fixed
// https://github.com/withastro/astro/issues/3559
test.skip('Vue component', async ({ astro, page }) => {
await page.goto('/');
const count = await page.locator('#vue-counter pre');
await expect(count, 'initial count updated to 0').toHaveText('0');
await astro.editFile('./src/components/VueCounter.vue', (content) =>
content.replace('ref(0)', 'ref(5)')
);
await expect(count, 'initial count updated to 5').toHaveText('5');
});
// TODO: track down a reliability issue in this test
// It seems to lost connection to the vite server in CI
test.skip('Svelte component', async ({ astro, page }) => {
await page.goto('/');
const count = page.locator('#svelte-counter pre');
await expect(count, 'initial count is 0').toHaveText('0');
await astro.editFile('./src/components/SvelteCounter.svelte', (content) =>
content.replace('background: white', 'background: rgb(230, 230, 230)')
content.replace('let count = 0;', 'let count = 5;')
);
await expect(svelteCounter, 'background color updated').toHaveCSS(
'background-color',
'rgb(230, 230, 230)'
);
await expect(count, 'initial count updated to 5').toHaveText('5');
});
});
});