Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

fix: check origin in static build (#12070)

Browse source 
* fix: check origin in static build

* address comment
This commit is contained in:
Emanuele Stoppa 2024-09-25 14:38:32 +01:00 • committed by GitHub
parent 61d248e581
commit 9693ad4ffa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/tame-pumpkins-swim.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes an issue where the check origin middleware was incorrectly injected when the build output was `"static"`

2
packages/astro/src/core/build/generate.ts
View file

@ -540,7 +540,7 @@ function createBuildManifest(
onRequest: middleware,
};
},
checkOrigin: settings.config.security?.checkOrigin ?? false,
checkOrigin: (settings.config.security?.checkOrigin && settings.buildOutput === "server") ?? false,
key,
envGetSecretEnabled: false,
};

2
packages/astro/src/core/build/plugins/plugin-manifest.ts
View file

@ -270,7 +270,7 @@ function buildManifest(
assets: staticFiles.map(prefixAssetPath),
i18n: i18nManifest,
buildFormat: settings.config.build.format,
checkOrigin: settings.config.security?.checkOrigin ?? false,
checkOrigin: (settings.config.security?.checkOrigin && settings.buildOutput === "server") ?? false,
serverIslandNameMap: Array.from(settings.serverIslandNameMap),
key: encodedKey,
envGetSecretEnabled:

3
packages/astro/src/vite-plugin-astro-server/plugin.ts
View file

@ -60,6 +60,7 @@ export default function createVitePluginAstroServer({
await createRouteManifest({ settings, fsMod }, logger), // TODO: Handle partial updates to the manifest
);
warnMissingAdapter(logger, settings);
pipeline.manifest.checkOrigin = settings.config.security.checkOrigin && settings.buildOutput === "server";
pipeline.setManifestData(routeManifest);
}
}
@ -160,7 +161,7 @@ export function createDevelopmentManifest(settings: AstroSettings): SSRManifest
componentMetadata: new Map(),
inlinedScripts: new Map(),
i18n: i18nManifest,
checkOrigin: settings.config.security?.checkOrigin ?? false,
checkOrigin: (settings.config.security?.checkOrigin && settings.buildOutput === "server") ?? false,
envGetSecretEnabled: false,
key: createKey(),
middleware() {