Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-20 22:12:38 -05:00
Code Issues Activity

fix noop overwrite image service regression (#8880)

Browse source 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
This commit is contained in:
Alexander Niebuhr 2023-10-25 22:01:43 +02:00 • committed by GitHub
parent e99586787b
commit 8c3d4a859a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/witty-waves-rhyme.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': minor
---
Moves the logic for overriding the image service out of core and into adapters. Also fixes a regression where a valid `astro:assets` image service configuration could be overridden.

10
packages/astro/src/integrations/index.ts
View file

@ -238,16 +238,6 @@ export async function runHookConfigDone({
);
}
}
if (!validationResult.assets) {
logger.warn(
'astro',
`The selected adapter ${adapter.name} does not support image optimization. To allow your project to build with the original, unoptimized images, the image service has been automatically switched to the 'noop' option. See https://docs.astro.build/en/reference/configuration-reference/#imageservice`
);
settings.config.image.service = {
entrypoint: 'astro/assets/services/noop',
config: {},
};
}
}
settings.adapter = adapter;
},