From 8aa17a64b46b8eaabfd1375fd6550ff93727aa81 Mon Sep 17 00:00:00 2001
From: Erika <3019731+Princesseuh@users.noreply.github.com>
Date: Mon, 11 Dec 2023 11:08:12 -0500
Subject: [PATCH] Add missing global attributes to JSX definition (#9404)

* fix: add some missing attributes to our JSX definitions

* chore: changeset

* fix: use empty string as type
---
 .changeset/dull-masks-eat.md  |  5 +++++
 packages/astro/astro-jsx.d.ts | 10 ++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)
 create mode 100644 .changeset/dull-masks-eat.md

diff --git a/.changeset/dull-masks-eat.md b/.changeset/dull-masks-eat.md
new file mode 100644
index 0000000000..b72dabb36d
--- /dev/null
+++ b/.changeset/dull-masks-eat.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixed some newer HTML attributes not being included in our type definitions
diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts
index 3f73bcc613..46202644a6 100644
--- a/packages/astro/astro-jsx.d.ts
+++ b/packages/astro/astro-jsx.d.ts
@@ -517,7 +517,8 @@ declare namespace astroHTML.JSX {
 			| 'search'
 			| 'send'
 			| undefined
-			| null;
+		| null;
+		exportparts?: string | undefined | null;
 		hidden?: boolean | string | undefined | null;
 		id?: string | undefined | null;
 		inert?: boolean | string | undefined | null;
@@ -533,18 +534,23 @@ declare namespace astroHTML.JSX {
 			| undefined
 			| null;
 		is?: string | undefined | null;
+
+		// Microdata API
 		itemid?: string | undefined | null;
 		itemprop?: string | undefined | null;
 		itemref?: string | undefined | null;
 		itemscope?: boolean | string | undefined | null;
 		itemtype?: string | undefined | null;
+
 		lang?: string | undefined | null;
+		part?: string | undefined | null;
+		popover?: boolean | string | undefined | null;
 		slot?: string | undefined | null;
 		spellcheck?: 'true' | 'false' | boolean | undefined | null;
 		style?: string | StyleObject | undefined | null;
 		tabindex?: number | string | undefined | null;
 		title?: string | undefined | null;
-		translate?: 'yes' | 'no' | undefined | null;
+		translate?: 'yes' | 'no' | '' | undefined | null;
 
 		// <command>, <menuitem>
 		radiogroup?: string | undefined | null;