Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-03 22:57:08 -05:00
Code Issues Activity

Fixes Response not being cloneable by middleware (#7623)

Browse source
This commit is contained in:
Matthew Phillips 2023-07-11 14:21:05 -04:00 • committed by GitHub
parent f0666b92c3
commit 86e19c7cf8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 37 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/tasty-beans-give.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Allow our Response wrapper to be cloneable

8
packages/astro/src/runtime/server/response.ts
View file

@ -52,6 +52,14 @@ function createResponseClass() {
} }
return super.arrayBuffer(); return super.arrayBuffer();
} }
clone() {
return new StreamingCompatibleResponse!(this.#body, {
status: this.status,
statusText: this.statusText,
headers: this.headers
});
}
}; };
return StreamingCompatibleResponse; return StreamingCompatibleResponse;

6
packages/astro/test/fixtures/middleware-dev/src/middleware.js vendored
View file

@ -18,6 +18,12 @@ const first = defineMiddleware(async (context, next) => {
return new Response(JSON.stringify(object), { return new Response(JSON.stringify(object), {
headers: response.headers, headers: response.headers,
}); });
} else if(context.url.pathname === '/clone') {
const response = await next();
const newResponse = response.clone();
const /** @type {string} */ html = await newResponse.text();
const newhtml = html.replace('<h1>testing</h1>', '<h1>it works</h1>');
return new Response(newhtml, { status: 200, headers: response.headers });
} else { } else {
if(context.url.pathname === '/') { if(context.url.pathname === '/') {
context.cookies.set('foo', 'bar'); context.cookies.set('foo', 'bar');

12
packages/astro/test/fixtures/middleware-dev/src/pages/clone.astro vendored Normal file
View file

@ -0,0 +1,12 @@
---
---
<html>
<head>
<title>Testing</title>
</head>
<body>
<h1>testing</h1>
</body>
</html>

6
packages/astro/test/middleware.test.js
View file

@ -73,6 +73,12 @@ describe('Middleware in DEV mode', () => {
let res = await fixture.fetch('/'); let res = await fixture.fetch('/');
expect(res.headers.get('set-cookie')).to.equal('foo=bar'); expect(res.headers.get('set-cookie')).to.equal('foo=bar');
}); });
it('should be able to clone the response', async () => {
let res = await fixture.fetch('/clone');
let html = await res.text();
expect(html).to.contain('<h1>it works</h1>');
});
}); });
describe('Middleware in PROD mode, SSG', () => { describe('Middleware in PROD mode, SSG', () => {