Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

yarn add should be used to install packages instead of yarn install (#9562)

Browse source 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
This commit is contained in:
Canaris 2024-01-02 22:52:22 +08:00 • committed by GitHub
parent 55e49b3ffb
commit 67e06f9db1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/poor-cars-battle.md Normal file
View file

@ -0,0 +1,5 @@
---
"@astrojs/upgrade": patch
---
Updates the command used for installing packages with pnpm and yarn

8
packages/upgrade/src/actions/install.ts
View file

@ -123,6 +123,8 @@ async function runInstallCommand(
const cwd = fileURLToPath(ctx.cwd);
if (ctx.packageManager === 'yarn') await ensureYarnLock({ cwd });
const installCmd = ctx.packageManager === 'yarn' || ctx.packageManager === 'pnpm' ? 'add' : 'install';
await spinner({
start: `Installing dependencies with ${ctx.packageManager}...`,
end: `Installed dependencies!`,
@ -132,7 +134,7 @@ async function runInstallCommand(
await shell(
ctx.packageManager,
[
'install',
installCmd,
...dependencies.map(
({ name, targetVersion }) => `${name}@${targetVersion.replace(/^\^/, '')}`
),
@ -144,7 +146,7 @@ async function runInstallCommand(
await shell(
ctx.packageManager,
[
'install',
installCmd,
'--save-dev',
...devDependencies.map(
({ name, targetVersion }) => `${name}@${targetVersion.replace(/^\^/, '')}`
@ -161,7 +163,7 @@ async function runInstallCommand(
error(
'error',
`Dependencies failed to install, please run the following command manually:\n${color.bold(
`${ctx.packageManager} install ${packages}`
`${ctx.packageManager} ${installCmd} ${packages}`
)}`
);
return ctx.exit(1);