Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-06 22:10:10 -05:00
Code Issues Activity

fix scroll restoration issue on webKit browsers (#9186)

Browse source 
* fix scroll restoration issue on webKit browsers

* add changeset

* Update .changeset/shaggy-socks-glow.md

* Update .changeset/shaggy-socks-glow.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
This commit is contained in:
Martin Trapp 2023-11-23 19:08:37 +01:00 committed by GitHub
parent 04fdc1c613
commit 607542c7cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/shaggy-socks-glow.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes a view transition issue on webKit browsers that prevented scrolling to #fragments

3
packages/astro/src/transitions/router.ts
View file

@ -194,7 +194,6 @@ const moveToLocation = (to: URL, from: URL, options: Options, historyState?: Sta
to.href to.href
); );
} }
history.scrollRestoration = 'manual';
} }
// now we are on the new page for non-history navigations! // now we are on the new page for non-history navigations!
// (with history navigation page change happens before popstate is fired) // (with history navigation page change happens before popstate is fired)
@ -213,12 +212,14 @@ const moveToLocation = (to: URL, from: URL, options: Options, historyState?: Sta
// because we are already on the target page ... // because we are already on the target page ...
// ... what comes next is a intra-page navigation // ... what comes next is a intra-page navigation
// that won't reload the page but instead scroll to the fragment // that won't reload the page but instead scroll to the fragment
history.scrollRestoration = 'auto';
location.href = to.href; location.href = to.href;
} else { } else {
if (!scrolledToTop) { if (!scrolledToTop) {
scrollTo({ left: 0, top: 0, behavior: 'instant' }); scrollTo({ left: 0, top: 0, behavior: 'instant' });
} }
} }
history.scrollRestoration = 'manual';
} }
}; };