Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

Actions: remove "action used with get" error (#11648)

Browse source 
* fix: remove "action used with get" error

* chore: remove unused import

* fix(test): does not throw on GET

* chore: changeset
This commit is contained in:
Ben Holmes 2024-08-08 07:43:25 -04:00 • committed by GitHub
parent 07b4ade25f
commit 589d35158d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 18 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/big-tables-pump.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes unexpected error when refreshing a POST request from a form using Actions.

12
packages/astro/src/actions/runtime/middleware.ts
View file

@ -1,9 +1,6 @@
import { yellow } from 'kleur/colors';
import type { APIContext, MiddlewareNext } from '../../@types/astro.js';
import {
ActionQueryStringInvalidError,
ActionsUsedWithForGetError,
} from '../../core/errors/errors-data.js';
import { ActionQueryStringInvalidError } from '../../core/errors/errors-data.js';
import { AstroError } from '../../core/errors/errors.js';
import { defineMiddleware } from '../../core/middleware/index.js';
import { formContentTypes, hasContentType } from './utils.js';
@ -46,13 +43,6 @@ export const onRequest = defineMiddleware(async (context, next) => {
return handlePost({ context, next, actionName });
}
if (context.request.method === 'GET' && actionName) {
throw new AstroError({
...ActionsUsedWithForGetError,
message: ActionsUsedWithForGetError.message(actionName),
});
}
if (context.request.method === 'POST') {
return handlePostLegacy({ context, next });
}

12
packages/astro/test/actions.test.js
View file

@ -200,6 +200,18 @@ describe('Astro Actions', () => {
assert.equal($('#error-code').text(), 'UNAUTHORIZED');
});
it('Ignores `_astroAction` name for GET requests', async () => {
const req = new Request('http://example.com/user-or-throw?_astroAction=getUserOrThrow', {
method: 'GET',
});
const res = await app.render(req);
assert.equal(res.ok, true);
const html = await res.text();
let $ = cheerio.load(html);
assert.ok($('#user'));
});
describe('legacy', () => {
it('Response middleware fallback', async () => {
const formData = new FormData();