Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-30 22:03:56 -05:00
Code Issues Activity

Fix: The problem getViteConfig() duplicates some config (#12312)

Browse source 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: bluwy <bjornlu.dev@gmail.com>
This commit is contained in:
koyopro 2024-10-29 13:14:20 +09:00 committed by GitHub
parent 0cfc69d499
commit 5642ef9029
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/slimy-sloths-fry.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes an issue where using `getViteConfig()` returns incorrect and duplicate configuration

3
packages/astro/src/core/middleware/vite-plugin.ts
View file

@ -21,9 +21,8 @@ export function vitePluginMiddleware({ settings }: { settings: AstroSettings }):
return {
name: '@astro/plugin-middleware',
config(opts, { command }) {
config(_, { command }) {
isCommandBuild = command === 'build';
return opts;
},
async resolveId(id) {
if (id === MIDDLEWARE_MODULE_ID) {

13
packages/astro/test/config-vite.test.js
View file

@ -2,6 +2,8 @@ import assert from 'node:assert/strict';
import { before, describe, it } from 'node:test';
import * as cheerio from 'cheerio';
import { loadFixture } from './test-utils.js';
import { getViteConfig } from '../dist/config/index.js'
import { resolveConfig } from 'vite';
describe('Vite Config', async () => {
let fixture;
@ -21,3 +23,14 @@ describe('Vite Config', async () => {
assert.match($('link').attr('href'), /\/assets\/testing-[a-z\d]+\.css/);
});
});
describe("getViteConfig", () => {
it("Does not change the default config.", async () => {
const command = "serve";
const mode = "test";
const configFn = getViteConfig({});
const config = await configFn({ command, mode });
const resolvedConfig = await resolveConfig(config, command, mode);
assert.deepStrictEqual(resolvedConfig.resolve.conditions, ["astro"]);
})
});