Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

Remove unused config in Vue JSX integration (#10687)

Browse source
This commit is contained in:
Bjorn Lu 2024-04-08 13:35:34 +08:00 committed by GitHub
parent a15975e41c
commit 4ea042c388
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/few-forks-taste.md Normal file
View file

@ -0,0 +1,5 @@
---
"@astrojs/vue": patch
---
Removes unused `jsxTransformOptions` and `jsxImportSource` options from the renderer config

1
packages/integrations/vue/package.json
View file

@ -42,7 +42,6 @@
"dependencies": { "dependencies": {
"@vitejs/plugin-vue": "^5.0.4", "@vitejs/plugin-vue": "^5.0.4",
"@vitejs/plugin-vue-jsx": "^3.1.0", "@vitejs/plugin-vue-jsx": "^3.1.0",
"@vue/babel-plugin-jsx": "^1.1.5",
"@vue/compiler-sfc": "^3.3.8" "@vue/compiler-sfc": "^3.3.8"
}, },
"devDependencies": { "devDependencies": {

18
packages/integrations/vue/src/index.ts
View file

@ -19,21 +19,6 @@ function getRenderer(): AstroRenderer {
}; };
} }
function getJsxRenderer(): AstroRenderer {
return {
name: '@astrojs/vue (jsx)',
clientEntrypoint: '@astrojs/vue/client.js',
serverEntrypoint: '@astrojs/vue/server.js',
jsxImportSource: 'vue',
jsxTransformOptions: async () => {
const jsxPlugin = (await import('@vue/babel-plugin-jsx')).default;
return {
plugins: [jsxPlugin],
};
},
};
}
function virtualAppEntrypoint(options?: Options): Plugin { function virtualAppEntrypoint(options?: Options): Plugin {
const virtualModuleId = 'virtual:@astrojs/vue/app'; const virtualModuleId = 'virtual:@astrojs/vue/app';
const resolvedVirtualModuleId = '\0' + virtualModuleId; const resolvedVirtualModuleId = '\0' + virtualModuleId;
@ -135,9 +120,6 @@ export default function (options?: Options): AstroIntegration {
hooks: { hooks: {
'astro:config:setup': async ({ addRenderer, updateConfig }) => { 'astro:config:setup': async ({ addRenderer, updateConfig }) => {
addRenderer(getRenderer()); addRenderer(getRenderer());
if (options?.jsx) {
addRenderer(getJsxRenderer());
}
updateConfig({ vite: await getViteConfiguration(options) }); updateConfig({ vite: await getViteConfiguration(options) });
}, },
}, },

3
pnpm-lock.yaml
View file

@ -5199,9 +5199,6 @@ importers:
'@vitejs/plugin-vue-jsx': '@vitejs/plugin-vue-jsx':
specifier: ^3.1.0 specifier: ^3.1.0
version: 3.1.0(vite@5.2.7)(vue@3.4.21) version: 3.1.0(vite@5.2.7)(vue@3.4.21)
'@vue/babel-plugin-jsx':
specifier: ^1.1.5
version: 1.2.2(@babel/core@7.24.3)
'@vue/compiler-sfc': '@vue/compiler-sfc':
specifier: ^3.3.8 specifier: ^3.3.8
version: 3.4.21 version: 3.4.21