Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

Rename Astro app to astro:home (#10112)

Browse source 
* Rename Astro app to astro:home

* Create silent-hotels-approve.md

---------

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
This commit is contained in:
Erika 2024-02-14 16:37:37 +01:00 committed by GitHub
parent e34eeb146e
commit 476b79a611
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/silent-hotels-approve.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Renames the home Astro Devoolbar App to `astro:home`

2
packages/astro/e2e/dev-toolbar-audits.test.js
View file

@ -16,7 +16,7 @@ test.afterAll(async () => {
});
test.describe('Dev Toolbar - Audits', () => {
test('can warn about perf issues zzz', async ({ page, astro }) => {
test('can warn about perf issues', async ({ page, astro }) => {
await page.goto(astro.resolveUrl('/audits-perf'));
const toolbar = page.locator('astro-dev-toolbar');

14
packages/astro/e2e/dev-toolbar.test.js
View file

@ -27,7 +27,7 @@ test.describe('Dev Toolbar', () => {
await page.goto(astro.resolveUrl('/'));
const toolbar = page.locator('astro-dev-toolbar');
const appButton = toolbar.locator('button[data-app-id="astro"]');
const appButton = toolbar.locator('button[data-app-id="astro:home"]');
const appButtonTooltip = appButton.locator('.item-tooltip');
await appButton.hover();
@ -38,10 +38,12 @@ test.describe('Dev Toolbar', () => {
await page.goto(astro.resolveUrl('/'));
const toolbar = page.locator('astro-dev-toolbar');
const appButton = toolbar.locator('button[data-app-id="astro"]');
const appButton = toolbar.locator('button[data-app-id="astro:home"]');
await appButton.click();
const astroAppCanvas = toolbar.locator('astro-dev-toolbar-app-canvas[data-app-id="astro"]');
const astroAppCanvas = toolbar.locator(
'astro-dev-toolbar-app-canvas[data-app-id="astro:home"]'
);
const astroWindow = astroAppCanvas.locator('astro-dev-toolbar-window');
await expect(astroWindow).toHaveCount(1);
await expect(astroWindow).toBeVisible();
@ -205,10 +207,12 @@ test.describe('Dev Toolbar', () => {
await expect(settingsWindow).toBeVisible();
// Click the astro app
appButton = toolbar.locator('button[data-app-id="astro"]');
appButton = toolbar.locator('button[data-app-id="astro:home"]');
await appButton.click();
const astroAppCanvas = toolbar.locator('astro-dev-toolbar-app-canvas[data-app-id="astro"]');
const astroAppCanvas = toolbar.locator(
'astro-dev-toolbar-app-canvas[data-app-id="astro:home"]'
);
const astroWindow = astroAppCanvas.locator('astro-dev-toolbar-window');
await expect(astroWindow).toHaveCount(1);
await expect(astroWindow).toBeVisible();

2
packages/astro/src/runtime/client/dev-toolbar/apps/astro.ts
View file

@ -27,7 +27,7 @@ interface IntegrationData {
let integrationData: IntegrationData;
export default {
id: 'astro',
id: 'astro:home',
name: 'Menu',
icon: 'astro:logo',
async init(canvas, eventTarget) {