Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-06 22:10:10 -05:00
Code Issues Activity

Adds an error message for non-string transition:name values (#10205)

Browse source
This commit is contained in:
Martin Trapp 2024-02-23 15:00:52 +01:00 committed by GitHub
parent dddbb09fe0
commit 459f74bc71
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/pretty-oranges-heal.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Adds an error message for non-string transition:name values

3
packages/astro/src/runtime/server/transition.ts
View file

@ -91,6 +91,9 @@ export function renderTransition(
animationName: TransitionAnimationValue | undefined, animationName: TransitionAnimationValue | undefined,
transitionName: string transitionName: string
) { ) {
if (typeof (transitionName ?? '') !== 'string') {
throw new Error(`Invalid transition name {${transitionName}}`);
}
// Default to `fade` (similar to `initial`, but snappier) // Default to `fade` (similar to `initial`, but snappier)
if (!animationName) animationName = 'fade'; if (!animationName) animationName = 'fade';
const scope = createTransitionScope(result, hash); const scope = createTransitionScope(result, hash);