Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

fix: Reflect the configuration for esbuild (#12676)

Browse source
This commit is contained in:
koyopro 2025-01-07 18:33:51 +09:00 • committed by GitHub
parent 9a3b48c5c3
commit 2ffc0fcab7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 28 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/seven-feet-juggle.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Allows configuring Astro modules TypeScript compilation with the `vite.esbuild` config

2
packages/astro/src/vite-plugin-astro/compile.ts
View file

@ -37,8 +37,8 @@ export async function compileAstro({
// Compile all TypeScript to JavaScript.
// Also, catches invalid JS/TS in the compiled output before returning.
esbuildResult = await transformWithEsbuild(transformResult.code, compileProps.filename, {
...compileProps.viteConfig.esbuild,
loader: 'ts',
target: 'esnext',
sourcemap: 'external',
tsconfigRaw: {
compilerOptions: {

25
packages/astro/test/units/vite-plugin-astro/compile.test.js
View file

@ -5,13 +5,12 @@ import { init, parse } from 'es-module-lexer';
import { resolveConfig } from 'vite';
import { compileAstro } from '../../../dist/vite-plugin-astro/compile.js';
const viteConfig = await resolveConfig({ configFile: false }, 'serve');
/**
* @param {string} source
* @param {string} id
*/
async function compile(source, id) {
async function compile(source, id, inlineConfig = {}) {
const viteConfig = await resolveConfig({ configFile: false, ...inlineConfig }, 'serve');
return await compileAstro({
compileProps: {
astroConfig: { root: pathToFileURL('/'), base: '/', experimental: {} },
@ -69,4 +68,24 @@ const name = 'world
assert.equal(names.includes('file'), true);
assert.equal(names.includes('url'), true);
});
describe('when the code contains syntax that is transformed by esbuild', () => {
let code = `\
---
using x = {}
---`;
it('should not transform the syntax by default', async () => {
const result = await compile(code, '/src/components/index.astro');
assert.equal(result.code.includes('using x = {}'), true);
});
it('should transform the syntax by esbuild.target', async () => {
const result = await compile(code, '/src/components/index.astro', {
esbuild: { target: 'es2018' },
});
assert.equal(result.code.includes('using x = {}'), false);
});
});
});