Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

internals: getPageDatasByHoistedScriptId & getPagesDatasByComponent

Browse source
This commit is contained in:
Goulven Clec'h 2024-04-25 18:20:07 +02:00
parent 2423ac2b1a
commit 29da012350
2 changed files with 23 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
packages/astro/src/core/build/internal.ts
View file

@ -233,17 +233,19 @@ export function getPageData(
}
/**
* TODO: remove this function, obsolete.
* last usage in astro/packages/astro/src/core/build/generate.ts
* Get all pages datas from the build internals, using a specific component.
* @param internals Build Internals with all the pages
* @param component path to the component, used to identify related pages
*/
export function getPageDataByComponent(
export function getPagesDatasByComponent(
internals: BuildInternals,
component: string
): PageBuildData | undefined {
if (internals.pagesByKeys.has(component)) {
return internals.pagesByKeys.get(component);
}
return undefined;
): PageBuildData[] {
const pageDatas: PageBuildData[] = [];
Array.from(internals.pagesByKeys.values()).forEach((pageData) => {
if (component === pageData.component) pageDatas.push(pageData);
})
return pageDatas;
}
/**
@ -360,21 +362,23 @@ export function mergeInlineCss(
return acc;
}
export function isHoistedScript(internals: BuildInternals, id: string): boolean {
return internals.hoistedScriptIdToPagesMap.has(id);
}
export function* getPageDatasByHoistedScriptId(
/**
* Get all pages data from the build internals, using a specific hoisted script id.
* @param internals Build Internals with all the pages
* @param id Hoisted script id, used to identify the pages using it
*/
export function getPageDatasByHoistedScriptId(
internals: BuildInternals,
id: string
): Generator<PageBuildData, void, unknown> {
): PageBuildData[]{
const set = internals.hoistedScriptIdToPagesMap.get(id);
const pageDatas: PageBuildData[] = [];
if (set) {
for (const pageId of set) {
const pageData = getPageDataByComponent(internals, pageId.slice(1));
if (pageData) {
yield pageData;
}
getPagesDatasByComponent(internals, pageId.slice(1)).forEach((pageData) => {
pageDatas.push(pageData);
});
}
}
return pageDatas;
}

3
packages/astro/src/core/build/plugins/plugin-css.ts
View file

@ -18,7 +18,6 @@ import {
getPageDataByViteID,
getPageDatasByClientOnlyID,
getPageDatasByHoistedScriptId,
isHoistedScript,
} from '../internal.js';
import { extendManualChunks, shouldInlineAsset } from './util.js';
@ -161,7 +160,7 @@ function rollupPluginAstroBuildCSS(options: PluginOptions): VitePlugin[] {
if (pageData) {
appendCSSToPage(pageData, meta, pagesToCss, depth, order);
}
} else if (options.target === 'client' && isHoistedScript(internals, pageInfo.id)) {
} else if (options.target === 'client' && internals.hoistedScriptIdToPagesMap.has(pageInfo.id)) {
for (const pageData of getPageDatasByHoistedScriptId(internals, pageInfo.id)) {
appendCSSToPage(pageData, meta, pagesToCss, -1, order);
}