Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

Ensure final asset directory exists before writing cached files (#12418)

Browse source 
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
This commit is contained in:
oliverlynch 2024-11-16 01:25:42 +08:00 committed by GitHub
parent cec4af8fe5
commit 25baa4ed0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/thick-shrimps-hammer.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fix cached image redownloading if it is the first asset

6
packages/astro/src/assets/build/generate.ts
View file

@ -153,6 +153,9 @@ export async function generateImagesForPath(
const isLocalImage = isESMImportedImage(options.src); const isLocalImage = isESMImportedImage(options.src);
const finalFileURL = new URL('.' + filepath, env.clientRoot); const finalFileURL = new URL('.' + filepath, env.clientRoot);
const finalFolderURL = new URL('./', finalFileURL);
await fs.promises.mkdir(finalFolderURL, { recursive: true });
// For remote images, instead of saving the image directly, we save a JSON file with the image data and expiration date from the server // For remote images, instead of saving the image directly, we save a JSON file with the image data and expiration date from the server
const cacheFile = basename(filepath) + (isLocalImage ? '' : '.json'); const cacheFile = basename(filepath) + (isLocalImage ? '' : '.json');
const cachedFileURL = new URL(cacheFile, env.assetsCacheDir); const cachedFileURL = new URL(cacheFile, env.assetsCacheDir);
@ -194,9 +197,6 @@ export async function generateImagesForPath(
// If the cache file doesn't exist, just move on, and we'll generate it // If the cache file doesn't exist, just move on, and we'll generate it
} }
const finalFolderURL = new URL('./', finalFileURL);
await fs.promises.mkdir(finalFolderURL, { recursive: true });
// The original filepath or URL from the image transform // The original filepath or URL from the image transform
const originalImagePath = isLocalImage const originalImagePath = isLocalImage
? (options.src as ImageMetadata).src ? (options.src as ImageMetadata).src