Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-30 22:03:56 -05:00
Code Issues Activity

Use logger instead of console

Browse source
This commit is contained in:
Luiz Ferraz 2024-10-11 07:17:57 -03:00
parent 1ba3ceb10c
commit 23767b51e5
No known key found for this signature in database
GPG key ID: B20E8273A6810404
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/astro/src/core/build/generate.ts
View file

@ -287,7 +287,7 @@ async function getPathsForRoute(
if (isRoute(route, matchedRoute)) { if (isRoute(route, matchedRoute)) {
paths.push(path); paths.push(path);
} else { } else {
console.log('Skipping mismatched route', path, route, matchedRoute); logger.warn('build', `Skipping conflicting route for "${path}" (${route.component})`);
} }
} else { } else {
const staticPaths = await callGetStaticPaths({ const staticPaths = await callGetStaticPaths({
@ -332,26 +332,25 @@ async function getPathsForRoute(
for (const matchedRoute of matchedRoutes) { for (const matchedRoute of matchedRoutes) {
// This is the highest priority matching route // This is the highest priority matching route
if (isRoute(route, matchedRoute)) { if (isRoute(route, matchedRoute)) {
console.log('matchedRoute', staticPath, matchedRoute.pattern);
return true; return true;
} }
// There is an on-demand route matching this path with a higher priority // There is an on-demand route matching this path with a higher priority
// skip rendering this path // skip rendering this path
if (!matchedRoute.prerender) { if (!matchedRoute.prerender) {
console.log('Skipped due to on-demand route', staticPath, matchedRoute.pattern); logger.warn('build', `Skipped building path "${staticPath}" due to on-demand route "${matchedRoute.route}"`);
return false; return false;
} }
// Path was already pre-rendered by a higher priority route // Path was already pre-rendered by a higher priority route
if (matchedRoute === renderingRoute) { if (matchedRoute === renderingRoute) {
console.log('Skipped due to higher priority pre-rendered route', staticPath, matchedRoute.pattern); logger.warn('build', `Skipped building path "${staticPath}" due to higher priority pre-rendered route "${matchedRoute.route}"`);
return false; return false;
} }
} }
// Route not matched, skip it // Route not matched, skip it
console.log('Skipped due to no matching route', staticPath, route.pathname, route.pattern); logger.error('build', `Route (${route.component}) generated path (${staticPath}) that doesn't match its own pattern (${route.route})`);
return false; return false;
}); });
} }
@ -388,10 +387,10 @@ function getInvalidRouteSegmentError(
...AstroErrorData.InvalidDynamicRoute, ...AstroErrorData.InvalidDynamicRoute,
message: invalidParam message: invalidParam
? AstroErrorData.InvalidDynamicRoute.message( ? AstroErrorData.InvalidDynamicRoute.message(
route.route, route.route,
JSON.stringify(invalidParam), JSON.stringify(invalidParam),
JSON.stringify(received), JSON.stringify(received),
) )
: `Generated path for ${route.route} is invalid.`, : `Generated path for ${route.route} is invalid.`,
hint, hint,
}); });