Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

Fix astro add generated import identifier (#12363)

Browse source
This commit is contained in:
Luiz Ferraz 2024-11-06 03:16:34 -03:00 committed by GitHub
parent 493fe43cd3
commit 222f71894c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/five-maps-bake.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes code generated by `astro add` command when adding a version of an integration other than the default `latest`.

7
packages/astro/src/cli/add/index.ts
View file

@ -390,13 +390,16 @@ function isAdapter(
// Some examples: // Some examples:
// - @astrojs/image => image // - @astrojs/image => image
// - @astrojs/markdown-component => markdownComponent // - @astrojs/markdown-component => markdownComponent
// - @astrojs/image@beta => image
// - astro-cast => cast // - astro-cast => cast
// - astro-cast@next => cast
// - markdown-astro => markdown // - markdown-astro => markdown
// - some-package => somePackage // - some-package => somePackage
// - example.com => exampleCom // - example.com => exampleCom
// - under_score => underScore // - under_score => underScore
// - 123numeric => numeric // - 123numeric => numeric
// - @npm/thingy => npmThingy // - @npm/thingy => npmThingy
// - @npm/thingy@1.2.3 => npmThingy
// - @jane/foo.js => janeFoo // - @jane/foo.js => janeFoo
// - @tokencss/astro => tokencss // - @tokencss/astro => tokencss
const toIdent = (name: string) => { const toIdent = (name: string) => {
@ -409,7 +412,9 @@ const toIdent = (name: string) => {
// convert to camel case // convert to camel case
.replace(/[.\-_/]+([a-zA-Z])/g, (_, w) => w.toUpperCase()) .replace(/[.\-_/]+([a-zA-Z])/g, (_, w) => w.toUpperCase())
// drop invalid first characters // drop invalid first characters
.replace(/^[^a-zA-Z$_]+/, ''); .replace(/^[^a-zA-Z$_]+/, '')
// drop version or tag
.replace(/@.*$/, '');
return `${ident[0].toLowerCase()}${ident.slice(1)}`; return `${ident[0].toLowerCase()}${ident.slice(1)}`;
}; };