Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

clean & comments

Browse source
This commit is contained in:
Goulven Clec'h 2024-04-09 20:10:59 +02:00
parent db7fdd20f5
commit 21885cc2ef
5 changed files with 4 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/astro/src/core/build/generate.ts
View file

@ -616,11 +616,7 @@ function createBuildManifest(
}
/**
*
* @param internals
* @param path
* @param route
* @returns
* TODO: Change that – document & maybe refactor
*/
function getEntryFilePath(internals: BuildInternals, pageData: RouteData) {
const id =

2
packages/astro/src/core/build/pipeline.ts
View file

@ -187,7 +187,7 @@ export class BuildPipeline extends Pipeline {
) {
const [, pageName] = entrypoint.split(':');
console.log('pageName', pageName);
// TODO: Change that
// TODO: Change that – tmp function use only component name and not the route
const pageData = tmp(
this.internals.pagesByKeys,
pageName.replace(ASTRO_PAGE_EXTENSION_POST_PATTERN, '.')

9
packages/astro/src/core/build/plugins/plugin-pages.ts
View file

@ -74,12 +74,3 @@ export function pluginPages(opts: StaticBuildOptions, internals: BuildInternals)
},
};
}
/**
* TMP: This is a temporary function to get the page data from the pagesByKeys map.
*/
function tmp(pagesByKeys: Map<string, any>, pageName: string) {
for (const pages of pagesByKeys.values()) {
if (pages.component == pageName) return pages;
}
}

2
packages/astro/src/core/build/plugins/plugin-ssr.ts
View file

@ -172,7 +172,7 @@ function vitePluginSSRSplit(
const imports: string[] = [];
const contents: string[] = [];
const exports: string[] = [];
// TODO: Change that
// TODO: Change that – broken usage of getVirtualModulePageName
const path = getPathFromVirtualModulePageName(RESOLVED_SPLIT_MODULE_ID, id);
const virtualModuleName = getVirtualModulePageName(ASTRO_PAGE_MODULE_ID, path);
let module = await this.resolve(virtualModuleName);

2
packages/astro/test/test-utils.js
View file

@ -221,7 +221,7 @@ export async function loadFixture(inlineConfig) {
return app;
},
loadEntryPoint: async (pagePath, routes, streaming) => {
// TODO: Change that
// TODO: Change that – broken usage of getVirtualModulePageName
const virtualModule = getVirtualModulePageName(RESOLVED_SPLIT_MODULE_ID, pagePath);
const filePath = makeSplitEntryPointFileName(virtualModule, routes);
const url = new URL(`./server/${filePath}?id=${fixtureId}`, config.outDir);