Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-27 22:19:04 -05:00
Code Issues Activity

Remove server-destroy dependency (#10132)

Browse source
This commit is contained in:
Bjorn Lu 2024-02-15 22:59:03 +08:00 • committed by GitHub
parent 1f598b3724
commit 1da9c5f2f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 6 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/poor-llamas-chew.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Simplifies internal Vite preview server teardown

2
packages/astro/package.json
View file

@ -166,7 +166,6 @@
"rehype": "^13.0.1",
"resolve": "^1.22.4",
"semver": "^7.5.4",
"server-destroy": "^1.0.1",
"shikiji": "^0.9.19",
"shikiji-core": "^0.9.19",
"string-width": "^7.0.0",
@ -210,7 +209,6 @@
"@types/resolve": "^1.20.5",
"@types/semver": "^7.5.2",
"@types/send": "^0.17.4",
"@types/server-destroy": "^1.0.3",
"@types/unist": "^3.0.2",
"@types/yargs-parser": "^21.0.3",
"astro-scripts": "workspace:*",

9
packages/astro/src/core/preview/static-preview-server.ts
View file

@ -1,7 +1,6 @@
import type http from 'node:http';
import { fileURLToPath } from 'node:url';
import { performance } from 'perf_hooks';
import enableDestroy from 'server-destroy';
import { preview, type PreviewServer as VitePreviewServer } from 'vite';
import type { AstroSettings } from '../../@types/astro.js';
import type { Logger } from '../logger/core.js';
@ -47,8 +46,6 @@ export default async function createStaticPreviewServer(
throw err;
}
enableDestroy(previewServer.httpServer);
// Log server start URLs
logger.info(
'SKIP_FORMAT',
@ -73,10 +70,6 @@ export default async function createStaticPreviewServer(
port: settings.config.server.port,
closed,
server: previewServer.httpServer as http.Server,
stop: async () => {
await new Promise((resolve, reject) => {
previewServer.httpServer.destroy((err) => (err ? reject(err) : resolve(undefined)));
});
},
stop: previewServer.close.bind(previewServer),
};
}

6
pnpm-lock.yaml generated
View file

@ -650,9 +650,6 @@ importers:
semver:
specifier: ^7.5.4
version: 7.5.4
server-destroy:
specifier: ^1.0.1
version: 1.0.1
shikiji:
specifier: ^0.9.19
version: 0.9.19
@ -772,9 +769,6 @@ importers:
'@types/send':
specifier: ^0.17.4
version: 0.17.4
'@types/server-destroy':
specifier: ^1.0.3
version: 1.0.3
'@types/unist':
specifier: ^3.0.2
version: 3.0.2