Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

fix: better isPromise check for proxy objects (#11178)

Browse source
This commit is contained in:
Theo Ephraim 2024-06-04 20:17:49 -07:00 • committed by GitHub
parent 3cfa2ac7e5
commit 1734c49f51
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/green-moose-fetch.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Improves `isPromise` utility to check the presence of `then` on an object before trying to access it - which can cause undesired side-effects on Proxy objects

2
packages/astro/src/runtime/server/util.ts
View file

@ -1,5 +1,5 @@
export function isPromise<T = any>(value: any): value is Promise<T> {
return !!value && typeof value === 'object' && typeof value.then === 'function';
return !!value && typeof value === 'object' && 'then' in value && typeof value.then === 'function';
}
export async function* streamAsyncIterator(stream: ReadableStream) {