diff --git a/benchmark/index.js b/benchmark/index.js index 956b9c3afa..0c62036d98 100755 --- a/benchmark/index.js +++ b/benchmark/index.js @@ -1,6 +1,6 @@ import fs from 'node:fs/promises'; import path from 'node:path'; -import { fileURLToPath, pathToFileURL } from 'node:url'; +import { pathToFileURL } from 'node:url'; import mri from 'mri'; import { makeProject } from './bench/_util.js'; diff --git a/benchmark/packages/adapter/src/index.ts b/benchmark/packages/adapter/src/index.ts index f2345deb08..0fc6d67f99 100644 --- a/benchmark/packages/adapter/src/index.ts +++ b/benchmark/packages/adapter/src/index.ts @@ -1,4 +1,4 @@ -import type { AstroAdapter, AstroIntegration } from 'astro'; +import type { AstroIntegration } from 'astro'; export default function createIntegration(): AstroIntegration { return { diff --git a/biome.jsonc b/biome.jsonc index bab1f1a05b..a1000760a7 100644 --- a/biome.jsonc +++ b/biome.jsonc @@ -34,6 +34,7 @@ "correctness": { "noUnusedVariables": "info", "noUnusedFunctionParameters": "info", + "noUnusedImports": "warn", }, }, }, @@ -87,11 +88,12 @@ }, }, { - "include": ["*.astro", "client.d.ts"], + "include": ["*.astro", "client.d.ts", "jsx-runtime.d.ts"], "linter": { "rules": { "correctness": { "noUnusedVariables": "off", + "noUnusedImports": "off", }, }, }, diff --git a/packages/astro/src/assets/utils/imageAttributes.ts b/packages/astro/src/assets/utils/imageAttributes.ts index 1b17e11b63..aa67b528f2 100644 --- a/packages/astro/src/assets/utils/imageAttributes.ts +++ b/packages/astro/src/assets/utils/imageAttributes.ts @@ -1,5 +1,4 @@ import { toStyleString } from '../../runtime/server/render/util.js'; -import type { AstroConfig } from '../../types/public/config.js'; import type { GetImageResult, ImageLayout, LocalImageProps, RemoteImageProps } from '../types.js'; export function addCSSVarsToStyle( diff --git a/packages/astro/src/core/app/index.ts b/packages/astro/src/core/app/index.ts index 36543b5cac..d23383133e 100644 --- a/packages/astro/src/core/app/index.ts +++ b/packages/astro/src/core/app/index.ts @@ -5,7 +5,6 @@ import { REROUTABLE_STATUS_CODES, REROUTE_DIRECTIVE_HEADER, clientAddressSymbol, - clientLocalsSymbol, responseSentSymbol, } from '../constants.js'; import { getSetCookiesFromResponse } from '../cookies/index.js'; diff --git a/packages/astro/src/core/build/plugins/plugin-manifest.ts b/packages/astro/src/core/build/plugins/plugin-manifest.ts index caebb470d5..f0589868f7 100644 --- a/packages/astro/src/core/build/plugins/plugin-manifest.ts +++ b/packages/astro/src/core/build/plugins/plugin-manifest.ts @@ -5,7 +5,6 @@ import type { Plugin as VitePlugin } from 'vite'; import { getAssetsPrefix } from '../../../assets/utils/getAssetsPrefix.js'; import { normalizeTheLocale } from '../../../i18n/index.js'; import { toFallbackType, toRoutingStrategy } from '../../../i18n/utils.js'; -import { unwrapSupportKind } from '../../../integrations/features-validation.js'; import { runHookBuildSsr } from '../../../integrations/hooks.js'; import { BEFORE_HYDRATION_SCRIPT_ID, PAGE_SCRIPT_ID } from '../../../vite-plugin-scripts/index.js'; import type { diff --git a/packages/astro/src/core/build/plugins/plugin-ssr.ts b/packages/astro/src/core/build/plugins/plugin-ssr.ts index 473aa95012..eea2be3e8e 100644 --- a/packages/astro/src/core/build/plugins/plugin-ssr.ts +++ b/packages/astro/src/core/build/plugins/plugin-ssr.ts @@ -1,5 +1,4 @@ import type { Plugin as VitePlugin } from 'vite'; -import type { AstroSettings } from '../../../types/astro.js'; import type { AstroAdapter } from '../../../types/public/integrations.js'; import { routeIsRedirect } from '../../redirects/index.js'; import { VIRTUAL_ISLAND_MAP_ID } from '../../server-islands/vite-plugin-server-islands.js'; diff --git a/packages/astro/src/vite-plugin-astro-server/route.ts b/packages/astro/src/vite-plugin-astro-server/route.ts index b4b6598054..eb353e501f 100644 --- a/packages/astro/src/vite-plugin-astro-server/route.ts +++ b/packages/astro/src/vite-plugin-astro-server/route.ts @@ -11,7 +11,7 @@ import { req } from '../core/messages.js'; import { loadMiddleware } from '../core/middleware/loadMiddleware.js'; import { routeIsRedirect } from '../core/redirects/index.js'; import { RenderContext } from '../core/render-context.js'; -import { type SSROptions, getProps } from '../core/render/index.js'; +import { getProps } from '../core/render/index.js'; import { createRequest } from '../core/request.js'; import { redirectTemplate } from '../core/routing/3xx.js'; import { matchAllRoutes } from '../core/routing/index.js'; diff --git a/packages/astro/templates/env.mjs b/packages/astro/templates/env.mjs index 9f36f1175b..6526033514 100644 --- a/packages/astro/templates/env.mjs +++ b/packages/astro/templates/env.mjs @@ -1,6 +1,7 @@ // @ts-check import { schema } from 'virtual:astro:env/internal'; import { + // biome-ignore lint/correctness/noUnusedImports: `_getEnv` is used by the generated code getEnv as _getEnv, createInvalidVariablesError, getEnvFieldType, diff --git a/packages/astro/test/units/routing/route-matching.test.js b/packages/astro/test/units/routing/route-matching.test.js index b524a7ea10..72900d3156 100644 --- a/packages/astro/test/units/routing/route-matching.test.js +++ b/packages/astro/test/units/routing/route-matching.test.js @@ -1,6 +1,5 @@ import * as assert from 'node:assert/strict'; import { after, before, describe, it } from 'node:test'; -import { fileURLToPath } from 'node:url'; import * as cheerio from 'cheerio'; import { createContainer } from '../../../dist/core/dev/container.js'; import { createViteLoader } from '../../../dist/core/module-loader/vite.js'; diff --git a/packages/db/src/core/integration/index.ts b/packages/db/src/core/integration/index.ts index 51d3f80116..36dc6b0f8b 100644 --- a/packages/db/src/core/integration/index.ts +++ b/packages/db/src/core/integration/index.ts @@ -26,7 +26,6 @@ import { type LateSeedFiles, type LateTables, type SeedHandler, - resolved, vitePluginDb, } from './vite-plugin-db.js'; diff --git a/packages/integrations/markdoc/src/html/transform/html-token-transform.ts b/packages/integrations/markdoc/src/html/transform/html-token-transform.ts index 2c6a5d1e2f..b80595f97b 100644 --- a/packages/integrations/markdoc/src/html/transform/html-token-transform.ts +++ b/packages/integrations/markdoc/src/html/transform/html-token-transform.ts @@ -1,6 +1,7 @@ import type { Tokenizer } from '@markdoc/markdoc'; import { Parser } from 'htmlparser2'; // @ts-expect-error This type isn't exported +// biome-ignore lint/correctness/noUnusedImports: not correctly detected because type isn't exported import type * as Token from 'markdown-it/lib/token'; export function htmlTokenTransform(tokenizer: Tokenizer, tokens: Token[]): Token[] {