Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-13 22:11:20 -05:00
Code Issues Activity

prettier-plugin: Add a test for JSX embedded in an attribute. This test currently fails. (#508)

Browse source 
* Add a test for JSX embedded in an attribute. This test currently fails.

* Oops forgot the semicolons on the correct output

* Add `--scope prettier-plugin-astro` so that the prettier plugin is tested on default CI

* Replace `assert.equal` with `assert.fixture` to remain inline w/ main

* Update astro-prettier.test.js

* Skip the other failing test.

Co-authored-by: Fred K. Schott <fkschott@gmail.com>
This commit is contained in:
Caleb Jasik 2021-06-25 17:21:03 -05:00 • committed by GitHub
parent 8aca0fabaf
commit 05d6fc66bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -17,7 +17,7 @@
"dev:vscode": "lerna run dev --scope astro-languageserver --scope astro-vscode --scope @astrojs/parser --parallel --stream", "dev:vscode": "lerna run dev --scope astro-languageserver --scope astro-vscode --scope @astrojs/parser --parallel --stream",
"format": "prettier -w \"**/*.{js,jsx,ts,tsx,md,json}\"", "format": "prettier -w \"**/*.{js,jsx,ts,tsx,md,json}\"",
"lint": "eslint \"packages/**/*.ts\"", "lint": "eslint \"packages/**/*.ts\"",
"test": "lerna run test --scope astro --stream", "test": "lerna run test --scope astro --scope prettier-plugin-astro --stream",
"test:core": "yarn workspace astro run test", "test:core": "yarn workspace astro run test",
"test:templates": "lerna run test --scope create-astro --stream" "test:templates": "lerna run test --scope create-astro --stream"
}, },

11
tools/prettier-plugin-astro/test/astro-prettier.test.js
View file

@ -33,7 +33,7 @@ Prettier('can format an Astro file with frontmatter', async () => {
assert.fixture(formatted, out); assert.fixture(formatted, out);
}); });
Prettier('can format an Astro file with embedded JSX expressions', async () => { Prettier.skip('can format an Astro file with embedded JSX expressions', async () => {
const [src, out] = await getFiles('embedded-expr'); const [src, out] = await getFiles('embedded-expr');
assert.not.fixture(src, out); assert.not.fixture(src, out);
@ -41,4 +41,13 @@ Prettier('can format an Astro file with embedded JSX expressions', async () => {
assert.fixture(formatted, out); assert.fixture(formatted, out);
}); });
// This is currently failing! See: https://github.com/snowpackjs/astro/issues/478
Prettier.skip('can format an Astro file with a JSX expression in an attribute', async () => {
const [src, out] = await getFiles('attribute-with-embedded-expr');
assert.not.fixture(src, out);
const formatted = format(src);
assert.fixture(formatted, out);
});
Prettier.run(); Prettier.run();

6
tools/prettier-plugin-astro/test/fixtures/in/attribute-with-embedded-expr.astro vendored Normal file
View file

@ -0,0 +1,6 @@
---
export let post
export let author
---
<a class="author" href={`/author/${post.author}`}>{author.name}</a>

6
tools/prettier-plugin-astro/test/fixtures/out/attribute-with-embedded-expr.astro vendored Normal file
View file

@ -0,0 +1,6 @@
---
export let post;
export let author;
---
<a class="author" href={`/author/${post.author}`}>{author.name}</a>